Skip to content

Commit

Permalink
Fixed #6657 -- Don't set secure attribute on cookie if secure=False
Browse files Browse the repository at this point in the history
… is passed, thanks Gulopine.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@7204 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information
gdub committed Mar 8, 2008
1 parent 444b7b2 commit 4d6f0f2
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions django/http/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -314,12 +314,18 @@ def items(self):
def get(self, header, alternate):
return self._headers.get(header.lower(), (None, alternate))[1]

def set_cookie(self, key, value='', max_age=None, expires=None, path='/', domain=None, secure=None):
def set_cookie(self, key, value='', max_age=None, expires=None, path='/', domain=None, secure=False):
self.cookies[key] = value
for var in ('max_age', 'path', 'domain', 'secure', 'expires'):
val = locals()[var]
if val is not None:
self.cookies[key][var.replace('_', '-')] = val
if max_age is not None:
self.cookies[key]['max-age'] = max_age
if expires is not None:
self.cookies[key]['expires'] = expires
if path is not None:
self.cookies[key]['path'] = path
if domain is not None:
self.cookies[key]['domain'] = domain
if secure:
self.cookies[key]['secure'] = True

def delete_cookie(self, key, path='/', domain=None):
self.set_cookie(key, max_age=0, path=path, domain=domain,
Expand Down

0 comments on commit 4d6f0f2

Please sign in to comment.