Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Fixed #12812 -- added warning about cyclic imports in contrib.comment…

…s. Thanks to Beetle_B, bjourne and philgyford for the reports, and Russ for the wording.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@14810 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 5a7af25c7a02ef6203a82acb6cc9098bb0b3d514 1 parent adfd7f8
Simon Meers authored

Showing 1 changed file with 12 additions and 0 deletions. Show diff stats Hide diff stats

  1. 12  docs/ref/contrib/comments/custom.txt
12  docs/ref/contrib/comments/custom.txt
@@ -110,6 +110,18 @@ point Django at these classes we've created::
110 110
     def get_form():
111 111
         return CommentFormWithTitle
112 112
 
  113
+
  114
+.. warning::
  115
+
  116
+    Be careful not to create cyclic imports in your custom comments app.
  117
+    If you feel your comment configuration isn't being used as defined --
  118
+    for example, if your comment moderation policy isn't being applied --
  119
+    you may have a cyclic import problem.
  120
+
  121
+    If you are having unexplained problems with comments behavior, check
  122
+    if your custom comments application imports (even indirectly)
  123
+    any module that itself imports Django's comments module.
  124
+
113 125
 The above process should take care of most common situations. For more
114 126
 advanced usage, there are additional methods you can define. Those are
115 127
 explained in the next section.

0 notes on commit 5a7af25

Please sign in to comment.
Something went wrong with that request. Please try again.