Skip to content

Commit

Permalink
Fixed #12812 -- added warning about cyclic imports in contrib.comment…
Browse files Browse the repository at this point in the history
…s. Thanks to Beetle_B, bjourne and philgyford for the reports, and Russ for the wording.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@14810 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information
DrMeers committed Dec 4, 2010
1 parent adfd7f8 commit 5a7af25
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions docs/ref/contrib/comments/custom.txt
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,18 @@ point Django at these classes we've created::
def get_form():
return CommentFormWithTitle


.. warning::

Be careful not to create cyclic imports in your custom comments app.
If you feel your comment configuration isn't being used as defined --
for example, if your comment moderation policy isn't being applied --
you may have a cyclic import problem.

If you are having unexplained problems with comments behavior, check
if your custom comments application imports (even indirectly)
any module that itself imports Django's comments module.

The above process should take care of most common situations. For more
advanced usage, there are additional methods you can define. Those are
explained in the next section.
Expand Down

0 comments on commit 5a7af25

Please sign in to comment.