Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #12812 -- added warning about cyclic imports in contrib.comment…

…s. Thanks to Beetle_B, bjourne and philgyford for the reports, and Russ for the wording.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@14810 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 5a7af25c7a02ef6203a82acb6cc9098bb0b3d514 1 parent adfd7f8
@DrMeers DrMeers authored
Showing with 12 additions and 0 deletions.
  1. +12 −0 docs/ref/contrib/comments/custom.txt
View
12 docs/ref/contrib/comments/custom.txt
@@ -110,6 +110,18 @@ point Django at these classes we've created::
def get_form():
return CommentFormWithTitle
+
+.. warning::
+
+ Be careful not to create cyclic imports in your custom comments app.
+ If you feel your comment configuration isn't being used as defined --
+ for example, if your comment moderation policy isn't being applied --
+ you may have a cyclic import problem.
+
+ If you are having unexplained problems with comments behavior, check
+ if your custom comments application imports (even indirectly)
+ any module that itself imports Django's comments module.
+
The above process should take care of most common situations. For more
advanced usage, there are additional methods you can define. Those are
explained in the next section.
Please sign in to comment.
Something went wrong with that request. Please try again.