[3.0.x] Fixed #30802 -- Prevented manifest creation when running coll…

…ectstatic in dry run mode. Backport of fa8fe09 from master
django · Sep 27, 2019 · 5d63bf0 · 5d63bf0
1 parent 0c655f1
commit 5d63bf0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/django/contrib/staticfiles/storage.py b/django/contrib/staticfiles/storage.py
@@ -403,7 +403,8 @@ def load_manifest(self):
     def post_process(self, *args, **kwargs):
         self.hashed_files = {}
         yield from super().post_process(*args, **kwargs)
-        self.save_manifest()
+        if not kwargs.get('dry_run'):
+            self.save_manifest()
 
     def save_manifest(self):
         payload = {'paths': self.hashed_files, 'version': self.manifest_version}

diff --git a/tests/staticfiles_tests/test_management.py b/tests/staticfiles_tests/test_management.py
@@ -334,6 +334,11 @@ def run_collectstatic(self):
         super().run_collectstatic(dry_run=True)
 
 
+@override_settings(STATICFILES_STORAGE='django.contrib.staticfiles.storage.ManifestStaticFilesStorage')
+class TestCollectionDryRunManifestStaticFilesStorage(TestCollectionDryRun):
+    pass
+
+
 class TestCollectionFilesOverride(CollectionTestCase):
     """
     Test overriding duplicated files by ``collectstatic`` management command.