Fixed #21291 -- Ensured inactive users cannot reset their passwords

Thanks kz26 for the report and the suggested fix. Refs #19758.

django/contrib/auth/forms.py

@@ -238,8 +238,9 @@ def save(self, domain_override=None,
         from django.core.mail import send_mail
         UserModel = get_user_model()
         email = self.cleaned_data["email"]
-        users = UserModel._default_manager.filter(email__iexact=email)
-        for user in users:
+        active_users = UserModel._default_manager.filter(
+            email__iexact=email, is_active=True)
+        for user in active_users:
             # Make sure that no email is sent to a user that actually has
             # a password marked as unusable
             if not user.has_usable_password():

django/contrib/auth/tests/test_forms.py

@@ -436,6 +436,7 @@ def test_inactive_user(self):
         user.save()
         form = PasswordResetForm({'email': email})
         self.assertTrue(form.is_valid())
+        form.save()
         self.assertEqual(len(mail.outbox), 0)
 
     def test_unusable_password(self):