Fixed #23088 -- Used six range type in Paginator.page_range.

django · Jul 25, 2014 · 6508db2 · 6508db2
1 parent bb395a1
commit 6508db2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/django/core/paginator.py b/django/core/paginator.py
@@ -96,7 +96,7 @@ def _get_page_range(self):
         Returns a 1-based range of pages for iterating through within
         a template for loop.
         """
-        return range(1, self.num_pages + 1)
+        return six.moves.range(1, self.num_pages + 1)
     page_range = property(_get_page_range)
 
 

diff --git a/tests/pagination/tests.py b/tests/pagination/tests.py
@@ -232,6 +232,13 @@ def test_get_page_hook(self):
         self.assertEqual(page2.previous_page_number(), 1)
         self.assertIsNone(page2.next_page_number())
 
+    def test_page_range_type(self):
+        """
+        Ticket #23088: Paginator.page_range is of inconsistent type in Py2/Py3
+        """
+        paginator = Paginator([1, 2, 3], 2)
+        self.assertEqual(type(paginator.page_range), six.moves.range)
+
 
 class ModelPaginationTests(TestCase):
     """