Skip to content

Commit

Permalink
Fixed #351 -- views.generic.list_detail.object_list now respects allo…
Browse files Browse the repository at this point in the history
…w_empty when paginating. Thanks, kmh

git-svn-id: http://code.djangoproject.com/svn/django/trunk@618 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information
adrianholovaty committed Sep 2, 2005
1 parent 5c22b8b commit 66d4db7
Showing 1 changed file with 11 additions and 8 deletions.
19 changes: 11 additions & 8 deletions django/views/generic/list_detail.py
Expand Up @@ -40,12 +40,15 @@ def object_list(request, app_label, module_name, paginate_by=None, allow_empty=F
try:
object_list = paginator.get_page(page)
except InvalidPage:
raise Http404
if page == 0 and allow_empty:
object_list = []
else:
raise Http404
page = int(page)
c = Context(request, {
'object_list': object_list,
'is_paginated' : True,
'results_per_page' : paginate_by,
'is_paginated': True,
'results_per_page': paginate_by,
'has_next': paginator.has_next_page(page),
'has_previous': paginator.has_previous_page(page),
'page': page + 1,
Expand All @@ -56,11 +59,11 @@ def object_list(request, app_label, module_name, paginate_by=None, allow_empty=F
else:
object_list = mod.get_list(**lookup_kwargs)
c = Context(request, {
'object_list' : object_list,
'is_paginated' : False
'object_list': object_list,
'is_paginated': False
})
if len(object_list) == 0 and not allow_empty:
raise Http404
if len(object_list) == 0 and not allow_empty:
raise Http404
for key, value in extra_context.items():
if callable(value):
c[key] = value()
Expand Down Expand Up @@ -103,7 +106,7 @@ def object_detail(request, app_label, module_name, object_id=None, slug=None,
else:
t = template_loader.get_template(template_name)
c = Context(request, {
'object' : object,
'object': object,
})
for key, value in extra_context.items():
if callable(value):
Expand Down

0 comments on commit 66d4db7

Please sign in to comment.