Skip to content

Commit

Permalink
To ensure that a model BooleanField has an explicit value set (and si…
Browse files Browse the repository at this point in the history
…nce it's

not required, by default), set the default properly in the constructor.

This code can be simplified when/if we resolve the
BooleanField/NullBooleanField overlap, but the current stuff is backwards
compatible. This would previously cause SQL errors on PostgreSQL and
interesting failures in subtle ways on MySQL and SQLite.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@8050 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information
malcolmt committed Jul 22, 2008
1 parent c51d000 commit 6ef47cf
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions django/db/models/fields/__init__.py
Expand Up @@ -477,6 +477,8 @@ def formfield(self, **kwargs):
class BooleanField(Field):
def __init__(self, *args, **kwargs):
kwargs['blank'] = True
if 'default' not in kwargs and not kwargs.get('null'):
kwargs['default'] = False
Field.__init__(self, *args, **kwargs)

def get_internal_type(self):
Expand Down

0 comments on commit 6ef47cf

Please sign in to comment.