Skip to content

Commit

Permalink
[3.0.x] Fixed #31073 -- Prevented CheckboxInput.get_context() from mu…
Browse files Browse the repository at this point in the history
…tating attrs.

Backport of 02eff7e from master
  • Loading branch information
PeteAndersen authored and felixxm committed Dec 11, 2019
1 parent 314cb3a commit 74e1454
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 3 deletions.
4 changes: 1 addition & 3 deletions django/forms/widgets.py
Expand Up @@ -522,9 +522,7 @@ def format_value(self, value):

def get_context(self, name, value, attrs):
if self.check_test(value):
if attrs is None:
attrs = {}
attrs['checked'] = True
attrs = {**(attrs or {}), 'checked': True}
return super().get_context(name, value, attrs)

def value_from_datadict(self, data, files, name):
Expand Down
5 changes: 5 additions & 0 deletions tests/forms_tests/widget_tests/test_checkboxinput.py
Expand Up @@ -89,3 +89,8 @@ def test_value_from_datadict_string_int(self):
def test_value_omitted_from_data(self):
self.assertIs(self.widget.value_omitted_from_data({'field': 'value'}, {}, 'field'), False)
self.assertIs(self.widget.value_omitted_from_data({}, {}, 'field'), False)

def test_get_context_does_not_mutate_attrs(self):
attrs = {'checked': False}
self.widget.get_context('name', True, attrs)
self.assertIs(attrs['checked'], False)
11 changes: 11 additions & 0 deletions tests/postgres_tests/test_array.py
Expand Up @@ -1003,6 +1003,17 @@ def test_get_context(self):
}
)

def test_checkbox_get_context_attrs(self):
context = SplitArrayWidget(
forms.CheckboxInput(),
size=2,
).get_context('name', [True, False])
self.assertEqual(context['widget']['value'], '[True, False]')
self.assertEqual(
[subwidget['attrs'] for subwidget in context['widget']['subwidgets']],
[{'checked': True}, {}]
)

def test_render(self):
self.check_html(
SplitArrayWidget(forms.TextInput(), size=2), 'array', None,
Expand Down

0 comments on commit 74e1454

Please sign in to comment.