Skip to content
Browse files

Fix a security issue in the admin. Disclosure and new release forthco…


git-svn-id: bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
alex committed Dec 23, 2010
1 parent 47fe010 commit 85207a245bf09fdebe486b4c7bbcb65300f2a693
@@ -10,7 +10,9 @@
from django.views.decorators.csrf import csrf_protect
from django.core.exceptions import PermissionDenied, ValidationError
from django.db import models, transaction
from django.db.models.fields import BLANK_CHOICE_DASH
from django.db.models.related import RelatedObject
from django.db.models.fields import BLANK_CHOICE_DASH, FieldDoesNotExist
from django.db.models.sql.constants import LOOKUP_SEP, QUERY_TERMS
from django.http import Http404, HttpResponse, HttpResponseRedirect
from django.shortcuts import get_object_or_404, render_to_response
from django.utils.decorators import method_decorator
@@ -183,6 +185,30 @@ def _declared_fieldsets(self):
def get_readonly_fields(self, request, obj=None):
return self.readonly_fields

def lookup_allowed(self, lookup):
parts = lookup.split(LOOKUP_SEP)

# Last term in lookup is a query term (__exact, __startswith etc)
# This term can be ignored.
if len(parts) > 1 and parts[-1] in QUERY_TERMS:

# Special case -- foo__id__exact and foo__id queries are implied
# if foo has been specificially included in the lookup list; so
# drop __id if it is the last part.
if len(parts) > 1 and parts[-1] ==

except FieldDoesNotExist:
# Lookups on non-existants fields are ok, since they're ignored
# later.
return True
clean_lookup = LOOKUP_SEP.join(parts)
return clean_lookup in self.list_filter or clean_lookup == self.date_hierarchy

class ModelAdmin(BaseModelAdmin):
"Encapsulates all admin options and functionality for a given model."

@@ -1,6 +1,7 @@
from django.contrib.admin.filterspecs import FilterSpec
from django.contrib.admin.options import IncorrectLookupParameters
from django.contrib.admin.util import quote
from django.core.exceptions import SuspiciousOperation
from django.core.paginator import Paginator, InvalidPage
from django.db import models
from django.db.models.query import QuerySet
@@ -187,13 +188,18 @@ def get_query_set(self):
lookup_params[key] = True

if not self.model_admin.lookup_allowed(key):
raise SuspiciousOperation(
"Filtering by %s not allowed" % key

# Apply lookup parameters from the query string.
qs = qs.filter(**lookup_params)
# Naked except! Because we don't have any other way of validating "params".
# They might be invalid if the keyword arguments are incorrect, or if the
# values are not in the correct type, so we might get FieldError, ValueError,
# ValicationError, or ? from a custom field that raises yet something else
# ValicationError, or ? from a custom field that raises yet something else
# when handed impossible data.
raise IncorrectLookupParameters
@@ -92,7 +92,7 @@ class ChapterInline(admin.TabularInline):

class ArticleAdmin(admin.ModelAdmin):
list_display = ('content', 'date', callable_year, 'model_year', 'modeladmin_year')
list_filter = ('date',)
list_filter = ('date', 'section')

def changelist_view(self, request):
"Test that extra_context works"
@@ -584,6 +584,9 @@ class Album(models.Model):
owner = models.ForeignKey(User)
title = models.CharField(max_length=30)

class AlbumAdmin(admin.ModelAdmin):
list_filter = ['title'], ArticleAdmin), CustomArticleAdmin), save_as=True, inlines=[ArticleInline])
@@ -630,4 +633,4 @@ class Album(models.Model):, PizzaAdmin), AlbumAdmin)
@@ -4,6 +4,7 @@
import datetime

from django.conf import settings
from django.core.exceptions import SuspiciousOperation
from django.core.files import temp as tempfile
# Register auth models with the admin.
from django.contrib.auth import REDIRECT_FIELD_NAME, admin
@@ -300,6 +301,10 @@ def testI18NLanguageNonEnglishFallback(self):
self.assertContains(response, 'Choisir une heure')

def test_disallowed_filtering(self):
self.client.get, "/test_admin/admin/admin_views/album/?owner__email__startswith=fuzzy"

class SaveAsTests(TestCase):
fixtures = ['admin-views-users.xml','admin-views-person.xml']

0 comments on commit 85207a2

Please sign in to comment.
You can’t perform that action at this time.