Skip to content

Commit

Permalink
[1.4.x] Fixed #20906 -- Fixed a dependence on set-ordering in tests
Browse files Browse the repository at this point in the history
Backport of 1ae64e9 from master
  • Loading branch information
spookylukey authored and timgraham committed Aug 16, 2013
1 parent bf611f1 commit d5da495
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions tests/regressiontests/admin_filters/tests.py
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -82,11 +82,11 @@ class DepartmentListFilterLookupWithNonStringValue(SimpleListFilter):
parameter_name = 'department' parameter_name = 'department'


def lookups(self, request, model_admin): def lookups(self, request, model_admin):
return set([ return sorted(set([
(employee.department.id, # Intentionally not a string (Refs #19318) (employee.department.id, # Intentionally not a string (Refs #19318)
employee.department.code) employee.department.code)
for employee in model_admin.queryset(request).all() for employee in model_admin.queryset(request).all()
]) ]))


def queryset(self, request, queryset): def queryset(self, request, queryset):
if self.value(): if self.value():
Expand Down Expand Up @@ -681,10 +681,9 @@ def test_lookup_with_non_string_value(self):
filterspec = changelist.get_filters(request)[0][-1] filterspec = changelist.get_filters(request)[0][-1]
self.assertEqual(force_unicode(filterspec.title), u'department') self.assertEqual(force_unicode(filterspec.title), u'department')
choices = list(filterspec.choices(changelist)) choices = list(filterspec.choices(changelist))

self.assertEqual(choices[1]['display'], 'DEV')
self.assertEqual(choices[2]['display'], u'DEV') self.assertEqual(choices[1]['selected'], True)
self.assertEqual(choices[2]['selected'], True) self.assertEqual(choices[1]['query_string'], '?department=%s' % self.john.pk)
self.assertEqual(choices[2]['query_string'], '?department=%s' % self.john.pk)


def test_fk_with_to_field(self): def test_fk_with_to_field(self):
""" """
Expand Down

0 comments on commit d5da495

Please sign in to comment.