Skip to content

Commit

Permalink
newforms-admin: Small cleanup of a bunch of _get_pk_val() calls.
Browse files Browse the repository at this point in the history
git-svn-id: http://code.djangoproject.com/svn/django/branches/newforms-admin@6840 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information
jkocherhans committed Dec 2, 2007
1 parent 081d0ed commit f0a54c0
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions django/newforms/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def __iter__(self):
if self.empty_label is not None:
yield (u"", self.empty_label)
for obj in self.queryset:
yield (obj._get_pk_val(), smart_unicode(obj))
yield (obj.pk, smart_unicode(obj))
# Clear the QuerySet cache if required.
if not self.cache_choices:
self.queryset._result_cache = None
Expand Down Expand Up @@ -266,7 +266,7 @@ def initial_data(instance, fields=None):
continue
if isinstance(f, ManyToManyField):
# MultipleChoiceWidget needs a list of ints, not object instances.
initial[f.name] = [obj._get_pk_val() for obj in f.value_from_object(instance)]
initial[f.name] = [obj.pk for obj in f.value_from_object(instance)]
else:
initial[f.name] = f.value_from_object(instance)
return initial
Expand Down Expand Up @@ -304,7 +304,7 @@ def save_existing_objects(self, commit=True):
# Put the objects from self.get_queryset into a dict so they are easy to lookup by pk
existing_objects = {}
for obj in self.queryset:
existing_objects[obj._get_pk_val()] = obj
existing_objects[obj.pk] = obj
saved_instances = []
for form in self.change_forms:
obj = existing_objects[form.cleaned_data[self.model._meta.pk.attname]]
Expand Down Expand Up @@ -367,7 +367,7 @@ def get_queryset(self):
return self.model._default_manager.filter(**kwargs)

def save_new(self, form, commit=True):
kwargs = {self.fk.get_attname(): self.instance.pk}
kwargs = {self.fk.get_attname(): self.instance._get_pk_val()}
new_obj = self.model(**kwargs)
return save_instance(form, new_obj, commit=commit)

Expand Down

0 comments on commit f0a54c0

Please sign in to comment.