Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Igbo language. #13155

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Added Igbo language. #13155

merged 1 commit into from
Jul 14, 2020

Conversation

PluckyPrecious
Copy link
Contributor

Created the integration patch for the newly added Igbo language for 3.1 release.

@felixxm
Copy link
Member

felixxm commented Jul 6, 2020

Adding a new language requires Transifex setup first. Do you intend to start a Igbo translation for Django and take the role of Igbo language coordinator? If you do, we can set it up on Transifex. Please give us your Transifex username. (\cc @claudep)

@felixxm felixxm closed this Jul 6, 2020
@claudep
Copy link
Member

claudep commented Jul 6, 2020

@felixxm, see https://groups.google.com/forum/#!topic/django-i18n/YzurStHQN5E

@claudep claudep reopened this Jul 6, 2020
@felixxm felixxm changed the title Added Support for Igbo language Added Igbo language. Jul 6, 2020
@felixxm
Copy link
Member

felixxm commented Jul 6, 2020

Thanks Claude.

claudep
claudep reviewed Jul 6, 2020
View reviewed changes
Copy link
Member

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! Yet some things to fix.

@PluckyPrecious
Copy link
Contributor Author

Adding a new language requires Transifex setup first. Do you intend to start a Igbo translation for Django and take the role of Igbo language coordinator? If you do, we can set it up on Transifex. Please give us your Transifex username. (\cc @claudep)

Hi @felixxm i have done the Transifex setup and started translation already. Here's my username- PluckyPrecious, thanks.

@felixxm
Copy link
Member

felixxm commented Jul 6, 2020

@PluckyPrecious Thanks 👍

@claudep
Copy link
Member

claudep commented Jul 6, 2020

It would be great if you could at least run flake8 tests to catch basic errors before pushing your modifications. Tell us if you need help doing that.

felixxm
felixxm reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PluckyPrecious Thanks 👍 I squashed commits and fixed formatting.

django/conf/locale/ig/formats.py Outdated Show resolved Hide resolved
@PluckyPrecious
Copy link
Contributor Author

@PluckyPrecious Thanks 👍 I squashed commits and fixed formatting.

Thanks a bunch @felixxm you rock.👍

@felixxm felixxm self-assigned this Jul 10, 2020
@felixxm
Copy link
Member

felixxm commented Jul 14, 2020

@PluckyPrecious Thanks 👍 Welcome aboard ⛵

@felixxm felixxm merged commit 2cd3e7e into django:master Jul 14, 2020
@PluckyPrecious
Copy link
Contributor Author

@PluckyPrecious Thanks 👍 Welcome aboard ⛵

Thank you. 😅

@felixxm felixxm mentioned this pull request Dec 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudep claudep claudep left review comments

@felixxm felixxm felixxm left review comments

Assignees

@felixxm felixxm

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@PluckyPrecious @felixxm @claudep