Skip to content

[5.0.x] Updated translations from Transifex.#17501

Merged
nessita merged 1 commit intodjango:stable/5.0.xfrom
nessita:translations-5.0
Dec 4, 2023
Merged

[5.0.x] Updated translations from Transifex.#17501
nessita merged 1 commit intodjango:stable/5.0.xfrom
nessita:translations-5.0

Conversation

@nessita
Copy link
Copy Markdown
Contributor

@nessita nessita commented Nov 21, 2023

This is not ready for review yet, I'm exercising the procedure of importing translations.

Questions/Comments:

  1. Plural forms for Spanish and French still need to be reverted
  2. After doing 1, do I need to re-generate the .mo files for those langs?
  3. Uyghur translations had errors, I fixed them manually in Transifex and re-fetched new translations

@felixxm
Copy link
Copy Markdown
Member

felixxm commented Nov 21, 2023

@nessita I think it's too soon for this PR, we still have two weeks for translators and there is no way to update it easily later as many steps have to be done manually.

@nessita
Copy link
Copy Markdown
Contributor Author

nessita commented Dec 1, 2023

This is still is WIP!!! 🛑

@nessita nessita force-pushed the translations-5.0 branch 5 times, most recently from 30464f6 to ac93a06 Compare December 2, 2023 17:17
@nessita
Copy link
Copy Markdown
Contributor Author

nessita commented Dec 2, 2023

@felixxm @claudep Hello! I believe this PR is ready for an initial review. I have:

  1. fetched all translations from transifex
  2. reverted those .po and .mo files without new translations
  3. reverted plural-forms for es*, fr, pt* and it

I still need to sed-and-replace the PO-Revision-Date to be newer on changed files, I will do so Monday.

A few notes: there were new translations files/folders for nl_BE, si (only a few resources) and for ug (most resources). I have added those to the repo as well. Then, I had questions about what we do with langs ending in Latin or Latn, so we track those as well?

Then, after the 5.0 final release, I would like to talk a bit about this process and how we could improve it, but I'll reach out about this separately. Thanks!

@nessita nessita marked this pull request as ready for review December 2, 2023 17:28
@felixxm
Copy link
Copy Markdown
Member

felixxm commented Dec 3, 2023

A few notes: there were new translations files/folders for nl_BE, si (only a few resources) and for ug (most resources). I have added those to the repo as well. Then, I had questions about what we do with langs ending in Latin or Latn, so we track those as well?

For adding a new language we require to at least fully translate the "core" resource on Transifex, then you have to prepare formats.py and make a few other changes including release notes (e.g. #12940, #12918, #13155, or #17163). That's not the case for nl_BE, si, pap, tlh, lg, please remove them from this patch.

@nessita
Copy link
Copy Markdown
Contributor Author

nessita commented Dec 3, 2023

A few notes: there were new translations files/folders for nl_BE, si (only a few resources) and for ug (most resources). I have added those to the repo as well. Then, I had questions about what we do with langs ending in Latin or Latn, so we track those as well?

For adding a new language we require to at least fully translate the "core" resource on Transifex, then you have to prepare formats.py and make a few other changes including release notes (e.g. #12940, #12918, #13155, or #17163). That's not the case for nl_BE, si, pap, tlh, lg, please remove them from this patch.

Thanks, I did not know.

Removed the languages and made a separated commit, I will squash tomorrow morning before the release (along with the PO-Revision-Date changes).

@felixxm
Copy link
Copy Markdown
Member

felixxm commented Dec 4, 2023

Then, I had questions about what we do with langs ending in Latin or Latn, so we track those as well?

I think so, however ug@Latin is practically empty. I'd remove it from this patch.

@felixxm
Copy link
Copy Markdown
Member

felixxm commented Dec 4, 2023

@nessita Thanks 👍 I checked all the files and they look good (except PO-Revision-Date). I only have the following comments:

  • I updated GIS translations for some languages to avoid missing translations caused by typographic changes, please refetch them:
    • django/contrib/gis/locale/eo/LC_MESSAGES/django.[pm]o
    • django/contrib/gis/locale/es_CO/LC_MESSAGES/django.[pm]o
    • django/contrib/gis/locale/ia/LC_MESSAGES/django.[pm]o
    • django/contrib/gis/locale/lt/LC_MESSAGES/django.[pm]o
    • django/contrib/gis/locale/mk/LC_MESSAGES/django.[pm]o
    • django/contrib/gis/locale/mn/LC_MESSAGES/django.[pm]o
    • django/contrib/gis/locale/sl/LC_MESSAGES/django.[pm]o
  • I don't see any new translated strings in the django/contrib/humanize/locale/zh_Hant/LC_MESSAGES/django.[pm]o, please revert it.

@nessita
Copy link
Copy Markdown
Contributor Author

nessita commented Dec 4, 2023

Then, I had questions about what we do with langs ending in Latin or Latn, so we track those as well?

I think so, however ug@Latin is practically empty. I'd remove it from this patch.

Sounds good, I removed it.

@nessita
Copy link
Copy Markdown
Contributor Author

nessita commented Dec 4, 2023

@nessita Thanks 👍 I checked all the files and they look good (except PO-Revision-Date). I only have the following comments:

* I updated GIS translations for some languages to avoid missing translations caused by typographic changes, please refetch them:
  
  * `django/contrib/gis/locale/eo/LC_MESSAGES/django.[pm]o`
  * `django/contrib/gis/locale/es_CO/LC_MESSAGES/django.[pm]o`
  * `django/contrib/gis/locale/ia/LC_MESSAGES/django.[pm]o`
  * `django/contrib/gis/locale/lt/LC_MESSAGES/django.[pm]o`
  * `django/contrib/gis/locale/mk/LC_MESSAGES/django.[pm]o`
  * `django/contrib/gis/locale/mn/LC_MESSAGES/django.[pm]o`
  * `django/contrib/gis/locale/sl/LC_MESSAGES/django.[pm]o`

* I don't see any new translated strings in the `django/contrib/humanize/locale/zh_Hant/LC_MESSAGES/django.[pm]o`, please revert it.

Applied all this and replaced the PO-Revision-Date field. I left each commit separated to ease the review, but once approved I squashed all the commits into one and merge.

@nessita nessita merged commit 8e1b820 into django:stable/5.0.x Dec 4, 2023
@nessita nessita deleted the translations-5.0 branch December 6, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants