Fixed #29504 -- Clarified interpretation of integer JSONField lookups. #10077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
changed the title
There was a problem hiding this comment.
Hi @ShaheedHaque. Thanks for making the PR here.
Looking at it, I'm not sure it's necessary. I appreciate you ran into a confusion, but an array index is only ever going to be applicable if you're indexing into an array. (i.e. if it's a dictionary it just doesn't make sense to interpret the integer that way — it must be a (string) dictionary key lookup.)
I might be tempted by just a shift from will to may:
If the key is an integer, it may be interpreted as an index lookup in an array.
... but I'm not sure it's significant enough to trigger re-translations.
Not sure. Perhaps others can comment.
|
I'm happy to leave the matter to your discretion. |
|
I think the current wording is okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Ticket 29504 this is an attempt to clarify the interpretation of "integer" keys.