Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completed test coverage for django.urls.utils.get_callable(). #10170

Merged
merged 1 commit into from Jul 19, 2018
Merged

Completed test coverage for django.urls.utils.get_callable(). #10170

merged 1 commit into from Jul 19, 2018

Conversation

hramezani
Copy link
Member

No description provided.

@timgraham
Copy link
Member

Could you try for complete coverage of get_callabe(), test the full message for each case, and put each case in a separate test method?

@hramezani
Copy link
Member Author

@timgraham sure, as soon as possible.

@hramezani hramezani force-pushed the increase_urls_utils_tests_coverage branch 4 times, most recently from 7c4cf63 to 83a4aca Compare July 19, 2018 07:31
@hramezani
Copy link
Member Author

@timgraham I added extra tests and separate the tests.
if I missed something please let me know.

@timgraham timgraham force-pushed the increase_urls_utils_tests_coverage branch from 83a4aca to 6bda1e2 Compare July 19, 2018 20:23
@timgraham timgraham changed the title Increase urls utils tests coverage Completed test coverage for django.urls.utils.get_callable(). Jul 19, 2018
@timgraham timgraham merged commit 55b6f7a into django:master Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hramezani @timgraham