Added asserts for all warnings in deprecation tests. #10172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tests run with Python warnings enables, catches warnings of the form: .../django/tests/deprecation/tests.py:77: DeprecationWarning: `Deprecated.old` method should be renamed `new`. class Deprecated(Renamed): .../django/tests/deprecation/tests.py:133: DeprecationWarning: `DeprecatedMixin.old` method should be renamed `new`. class Deprecated(DeprecatedMixin, RenamedMixin, Renamed): .../django/tests/deprecation/tests.py:54: DeprecationWarning: `Manager.old` method should be renamed `new`. class Manager(metaclass=RenameManagerMethods): .../django/tests/deprecation/tests.py:96: DeprecationWarning: `Deprecated.old` method should be renamed `new`. class Deprecated(metaclass=RenameManagerMethods):
carltongibson
approved these changes
Jul 11, 2018
There was a problem hiding this comment.
Yes, good. I saw these when checking #10164: nice one picking them up.
I'll just hold off merging because of the CI failure (which is unrelated but...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tests run with Python warnings enabled, catches warnings of the form: