Fixed #29563 -- Added result streaming for QuerySet.iterator() on SQLite. #10203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Split the request into two commits as per the feedback: one fixes the logic bug in execute_sql(), the second enables the can_use_chunked_reads flag for SQLite. |
|
I think the test in the first commit should mock The second commit should have a |
|
Good idea, I've updated the test. I added a bullet to the 2.2 release notes and the annotation as well. Let me know if it should go into more detail. I kept it brief. |
…tures.can_use_chunked_reads.
timgraham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that enabled Queryset.iterator() in SQLite in contrary to
the documentation. Updated the documentation and enabled the
can_use_chunked_reads flag in SQLite.
https://code.djangoproject.com/ticket/29563
I have yet to incorporate the latest feedback from the ticket comments, but I'm opening this now to get the CI tests.