Fixed #29686 -- Made UserAdmin.user_change_password() pass object to has_change_permission(). #10253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
force-pushed
the
auth_permissions
branch
from
aa3a943
to
8a329bb
Compare
atodorov
changed the title
|
The failing Jenkins job says |
|
Thanks for the contribution. A Trac ticket and a test are required. |
|
@timgraham do you think there is a valid case for this? Are you still interested in working on this @atodorov? I can create the ticket and modify the tests to get this PR ready. |
atodorov
force-pushed
the
auth_permissions
branch
2 times, most recently
from
d2f6ae3
to
9625f4d
Compare
|
@jeffyancey added a new test, should be good to go. |
|
The change and test both look good to me, but you still need to make a Trac ticket as directed by @timgraham |
timgraham
changed the title
…has_change_permission().
timgraham
force-pushed
the
auth_permissions
branch
from
9625f4d
to
7159428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/29686