Added getattr for profilefield in order to be used as the same model #10341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
suggested changes
Aug 27, 2018
There was a problem hiding this comment.
Hi @FJLendinez.
We can't add something like this I'm afraid. We can't tie django.db into your specific project field. (We can't even tie django.db into django.contrib.auth.)
If you're looking for features similar to this I suggest you try discussing your needs on django-users or StackOverflow or similar to see what suggestions people have. Then please see the contributing guide if you want to propose new features.
| @@ -547,6 +547,16 @@ def __setstate__(self, state): | |||
|
|
|||
| self.__dict__.update(state) | |||
|
|
|||
| def __getattr__(self, name) | |||
| try: | ||
| return object.__getattribute__(self, item) | ||
| except AttributeError: | ||
| ProfileField = self._meta.ProfileField |
There was a problem hiding this comment.
We can't add a reference to a project specific field in models/base.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this function we override the standard behaviour of getattr in order to find first in the object if it has the attr and, if it is defined, find over the profilefield model.