Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #29770 -- Added LinearRing.is_counterclockwise property. #10403

Merged
merged 1 commit into from Oct 25, 2019

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd
Copy link
Member Author

I checked that all tests pass on GEOS 3.7, so documented it as supported.

django/contrib/gis/geos/coordseq.py Outdated Show resolved Hide resolved
django/contrib/gis/geos/coordseq.py Outdated Show resolved Hide resolved
tests/gis_tests/geos_tests/test_geos.py Outdated Show resolved Hide resolved
@sir-sigurd sir-sigurd changed the title Fixed #29770 -- Added LinearRing.is_ccw property. [WIP] Fixed #29770 -- Added LinearRing.is_ccw property. Sep 26, 2018
Parth1811 added a commit to Parth1811/django that referenced this pull request Jun 17, 2019
…nlineFormSet

This patch inlcude the classes FormSet, ModelFormSet and InlineFormSet from
which other class can be directly inherited to create a formset class instead of
using the default factory functions.

!! REVIEW IS REQUIRED FOR THIS PATCH !!
Parth1811 added a commit to Parth1811/django that referenced this pull request Jun 19, 2019
…nlineFormSet

This patch inlcude the classes FormSet, ModelFormSet and InlineFormSet from
which other class can be directly inherited to create a formset class instead of
using the default factory functions.
@sir-sigurd sir-sigurd force-pushed the geos-is-ccw branch 3 times, most recently from b0bca08 to 1f04510 Compare October 17, 2019 10:49
@sir-sigurd sir-sigurd changed the title [WIP] Fixed #29770 -- Added LinearRing.is_ccw property. Fixed #29770 -- Added LinearRing.is_ccw property. Oct 17, 2019
Copy link
Member

@ngnpope ngnpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back @sir-sigurd!

This looks pretty much complete now. Thanks for dusting it off and polishing it up.

django/contrib/gis/geos/coordseq.py Outdated Show resolved Hide resolved
django/contrib/gis/geos/linestring.py Outdated Show resolved Hide resolved
django/contrib/gis/geos/coordseq.py Show resolved Hide resolved
docs/ref/contrib/gis/geos.txt Outdated Show resolved Hide resolved
tests/gis_tests/geos_tests/test_geos.py Outdated Show resolved Hide resolved
tests/gis_tests/geos_tests/test_geos.py Outdated Show resolved Hide resolved
@felixxm felixxm self-assigned this Oct 25, 2019
@felixxm felixxm changed the title Fixed #29770 -- Added LinearRing.is_ccw property. Fixed #29770 -- Added LinearRing.is_counterclockwise property. Oct 25, 2019
@felixxm
Copy link
Member

felixxm commented Oct 25, 2019

@sir-sigurd Thanks for this patch 👍 I pushed minor edits and renamed is_ccw to is_counterclockwise.

@felixxm felixxm merged commit 6bbf9a2 into django:master Oct 25, 2019
@sir-sigurd sir-sigurd deleted the geos-is-ccw branch October 26, 2019 16:48
Mitchina pushed a commit to Mitchina/django that referenced this pull request Feb 11, 2024
…nlineFormSet

This patch inlcude the classes FormSet, ModelFormSet and InlineFormSet from
which other class can be directly inherited to create a formset class instead of
using the default factory functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants