Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #29966 -- Add test coverage for BaseHandler's "The view didn't return an HttpResponse object." error #10675

Merged
merged 1 commit into from Nov 24, 2018

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Nov 21, 2018

ticket_29966

It covers FBV:

if isinstance(callback, types.FunctionType): # FBV

But I don't know how to test the CBV. I test some class-based view like this:

class WithoutReponse(ListView):

    def get(self, request):
        pass

But, when I call this view, the callback type is FunctionType and the else block doesn't execute.

@hramezani hramezani force-pushed the ticket_29966 branch 2 times, most recently from 00780b4 to a04e33e Compare November 22, 2018 09:23
@hramezani
Copy link
Member Author

@timgraham ClassBasedView test added based on your comment on ticket. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants