Fixed #30058 -- Made SMTP EmailBackend.send_messages() return 0 for empty/error cases. #10784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how could I restart the failed check? |
the restart didn't help :( well, it seems to be broken not by me |
|
@stebunovd Build on windows sometimes has issues after force-push. I restarted this build and it looks good. Please add a trac ticket for this change. |
|
thanks! The ticket: https://code.djangoproject.com/ticket/30058 |
charettes
changed the title
charettes
reviewed
Dec 23, 2018
|
Hey @stebunovd, thanks for the PR! Please uncheck patch needs improvement on the Trac ticket once you've added a test for the |
|
hey @charettes, I have added the test and unchecked patch needs improvement box. Thanks! |
timgraham
changed the title
…mpty/error cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/30058
This PR ensures that SMTP EmailBackend.send_messages() always returns an integer