Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #30117 -- Fixed SchemaEditor.quote_value() test for mysqlclient 1.4.0+. #10865

Merged
merged 1 commit into from Jan 19, 2019
Merged

Fixed #30117 -- Fixed SchemaEditor.quote_value() test for mysqlclient 1.4.0+. #10865

merged 1 commit into from Jan 19, 2019

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Jan 18, 2019

Behavior has been changed in PyMySQL/mysqlclient@819688b.

@ngnpope
Copy link
Member

ngnpope commented Jan 18, 2019

Looks like there are a couple more tests that need fixing…

@felixxm
Copy link
Member Author

felixxm commented Jan 18, 2019

@pope1ni IMO remaining two failures are related with issue in the mysqlclient==1.4.0 (see #30117 and PyMySQL/mysqlclient#323).

@charettes
Copy link
Member

I guess we could mysqlclient >= 1.3.13, != 1.4.0 to get CI passing again until this is resolved?

@felixxm
Copy link
Member Author

felixxm commented Jan 19, 2019 •
edited

@charettes I don't think so. mysqlclient==1.4.1 is already released 🎉 (see 1.4.1).

timgraham
timgraham approved these changes Jan 19, 2019
View reviewed changes
Copy link
Member

@timgraham timgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Fixed" for the commit message then? It wouldn't hurt to update the Trac ticket's title since it turned out to require only fixing a test failure.

@felixxm felixxm changed the title Refs #30117 -- Fixed SchemaEditor.quote_value() test for mysqlclient 1.4.0+. Fixed #30117 -- Fixed SchemaEditor.quote_value() test for mysqlclient 1.4.0+. Jan 19, 2019
@felixxm felixxm merged commit f05c02c into django:master Jan 19, 2019
@felixxm felixxm deleted the refs-30115 branch January 19, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charettes charettes charettes approved these changes

@timgraham timgraham timgraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@felixxm @ngnpope @charettes @timgraham