Refs #29714 -- Added support for SafeExceptionReporterFilter to filter sensitive cookies

[nasirhjafri]

https://code.djangoproject.com/ticket/29714

[carltongibson]

Hi @nasirhjafri.

Thanks for this.

The approach here isn't right for what's on the ticket. There, the idea is to make ExceptionReporter an attribute on AdminHandler so that it can be easily subclassed.

On the adjustments to SafeExceptionReporterFilter :

In general, there are a number of very similar requests to customise the error reporter output. (Not ALL of those, but several...) — If we added API to SafeExceptionReporterFilter for each of them, it'll become out of hand, so it's likely we need to favour a different approach. Whatever solution we take, I think we need to consider all the tickets here. (There's thoughts of deprecating SafeExceptionReporterFilter as the extension point entirely...)

In particular, adding settings wouldn't be the way to go. Rather adding attributes that could be overridden in a subclass would be preferred.

I'm going to close this as-is. If you want to re-open another PR exposing ExceptionReporteronAdminHandler` that would be great.

Thanks again.