Fixed #30199 -- Safer docs for QuerySet.get_or_create(). #11017
Conversation
alexbecker
force-pushed
the
docs-get-or-create
branch
from
abebd90
to
5ce9f56
Compare
alexbecker
changed the title
alexbecker
changed the title
|
Hey @adamchainz. Can I just ask for your input (if you have any 🙂) on this? (In seems a bit nitty-gritty for the |
|
OK, I'm going to mark this as "needs improvement" because there's at least Tim's point, but also, it looks to me as if Django's default configuration is now largely correct. (Tell me I'm wrong...:) As such, I think moving this to the DB ref would be better. (Again...:) I didn't follow-up the "phantom rows" link, but again is that appropriate for the As I say, if I missed something, please say. |
alexbecker
force-pushed
the
docs-get-or-create
branch
from
5ce9f56
to
6b839c8
Compare
|
@carltongibson I think I've addressed the review issues. Thanks for the feedback and sorry for letting this PR linger. |
alexbecker
force-pushed
the
docs-get-or-create
branch
from
6b839c8
to
678a560
Compare
|
I believe this is ready. |
|
OK, @adamchainz has approved it so I'll mark it RFC — "Ready for checkin" on Trac — (which any reviewer is welcome to do BTW... hint, hint... 🙂) — This'll help me get to it quicker. Thanks for the effort @alexbecker — I've seen this go past a few times. 🙂 |
Clarified how get_or_create() relates to the example try/except code, which has a race condition that get_or_create() exists in part to prevent, rather than just being more verbose. Made the warning about non-unique kwargs an explicit warning box, moved it up in the section so more people will read it, and made it more actionable. Removed the advice to change the MySQL isolation level to "READ COMMITTED", since that is now django's default. Moved the warning about data loss at "REPEATABLE READ" into the "Isolation level" section of the MySQL database documentation.
carltongibson
force-pushed
the
docs-get-or-create
branch
from
678a560
to
a7e7077
Compare
Clarified how get_or_create() relates to the example try/except code,
which has a race condition that get_or_create() exists in part to
prevent.
Made the warning about non-unique kwargs an explicit warning box, moved
it up in the section so more people will read it, and made it more
actionable.
Stopped advising MySQL users to lower the isolation level, and instead
explained the advantage of doing so but also the problems it may cause.
Added links to the relevant MySQL documentation.