Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #30220 -- Added support for headless mode in selenium tests. #11033

Merged
merged 1 commit into from May 17, 2019
Merged

Fixed #30220 -- Added support for headless mode in selenium tests. #11033

merged 1 commit into from May 17, 2019

Conversation

codingjoe
Copy link
Sponsor Contributor

@codingjoe codingjoe commented Feb 27, 2019 •
edited

Both Chrome and Firefox support a new headless mode now. Besides
being faster, it also is more reliable as well as convenient since
there are no windows popping up.

@codingjoe codingjoe changed the title Swichted Selenium to headless browsers [ ](/codingjoe) [Fix #30220 -- Headless browser mode for selenium test](/django/django/pull/11033/commits/ee2fa158f9333fb1b0a1dea5224733720300cbd6) Feb 27, 2019
@codingjoe codingjoe changed the title [ ](/codingjoe) [Fix #30220 -- Headless browser mode for selenium test](/django/django/pull/11033/commits/ee2fa158f9333fb1b0a1dea5224733720300cbd6) Fix #30220 -- Headless browser mode for selenium test Feb 27, 2019
@codingjoe codingjoe changed the title Fix #30220 -- Headless browser mode for selenium test Fixed #30220 -- Headless browser mode for selenium test Feb 27, 2019
@auvipy
Copy link
Contributor

auvipy commented Apr 5, 2019

could you check the flake8 issue when you back to this?

@codingjoe codingjoe force-pushed the issues/30220 branch 2 times, most recently from fc40867 to e908985 Compare April 6, 2019 09:32
@codingjoe
Copy link
Sponsor Contributor Author

@auvipy done :)

@apollo13
Copy link
Member

I've looked it through and tested it, works fine on my box! I'll leave it to @carltongibson for a final review (do we need release notes?).

@apollo13 apollo13 self-requested a review April 10, 2019 19:55
@carltongibson
Copy link
Member

Okay. Thanks both. I’ll give this a run just as soon as I recover from DjangoCon. 🙂

I think a mention in the release notes is justified. This is a cool addition.

@codingjoe
Copy link
Sponsor Contributor Author

hey @carltongibson, I hope you have recovered and all is well. I added a release note. Just amend any changes you want to make to the wording. best joe

@carltongibson
Copy link
Member

Super @codingjoe. Let us just get 2.2.1 out the way and we'll give this the last once-over and pull it in. Great effort!

@codingjoe
Copy link
Sponsor Contributor Author

hm... our build system is far from stable it seems

@django django deleted a comment from codingjoe May 15, 2019
@django django deleted a comment from carltongibson May 15, 2019
carltongibson
carltongibson approved these changes May 15, 2019
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.

I'm seeing intermittent errors using the --headless flag, which are problems with the driver I guess. (Check versions etc...)

But I think we should have it as-is. It's a nice addition. ≈1/3rd time saving on a good run. (And no mind-boggling pop-ups! 💃)

Thanks for the work @codingjoe!

@apollo13
Copy link
Member

apollo13 commented May 15, 2019 •
edited

Hrmpf, something is wonky with the trigger, jenkins says:

Bad configured project pull-requests-selenium - GitHub project property is not defined. Can't setup GitHub trigger for job pull-requests-selenium

followed by a nullpointer exception :/

@carltongibson
Copy link
Member

Tim, from the ticket:

Jenkins uses xfvb-run to run the tests headlessly

@apollo13
Copy link
Member

Yeah that is all installed and well but the triggers seem to be broken

@apollo13
Copy link
Member

I am testing on #11367

@apollo13
Copy link
Member

Ok, they seem to work again.

@felixxm
Copy link
Member

felixxm commented May 15, 2019

@codingjoe Thanks for this PR 👍 I pushed minor edits.

@django django deleted a comment from apollo13 May 15, 2019
@felixxm felixxm changed the title Fixed #30220 -- Headless browser mode for selenium test Fixed #30220 -- Added support for headless mode in selenium tests. May 17, 2019
@felixxm felixxm merged commit 8d010f3 into django:master May 17, 2019
@codingjoe codingjoe deleted the issues/30220 branch May 17, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy left review comments

@carltongibson carltongibson carltongibson approved these changes

@apollo13 apollo13 apollo13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@codingjoe @auvipy @apollo13 @carltongibson @felixxm