Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #30221 -- Made label suffix of admin's read-only fields translatable. #11034

Merged
merged 1 commit into from Feb 28, 2019
Merged

Fixed #30221 -- Made label suffix of admin's read-only fields translatable. #11034

merged 1 commit into from Feb 28, 2019

Conversation

etchove
Copy link
Contributor

@etchove etchove commented Feb 27, 2019 •
edited by timgraham

@etchove etchove changed the title Fixed #30221 -- Use self.form.label_suffix in AdminReadonly Fixed #30221 -- Use self.form.label_suffix in AdminReadonlyField Feb 27, 2019
@timgraham
Copy link
Member

That doesn't seem to be a regression test since the title field isn't read-only.

@etchove
Copy link
Contributor Author

etchove commented Feb 28, 2019 •
edited

I've changed the test just before commit. Shame on me :-)
It should be good now.

@timgraham timgraham changed the title Fixed #30221 -- Use self.form.label_suffix in AdminReadonlyField Fixed #30221 -- Made label suffix of admin's read-only fields translatable. Feb 28, 2019
@timgraham timgraham merged commit 4dcbe6e into django:master Feb 28, 2019
@etchove etchove deleted the admin_disabled_field branch March 13, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@etchove @timgraham