Fixed #28431 -- Added a system check for BinaryField to prevent strings defaults. #11088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
changed the title
felixxm
reviewed
Mar 25, 2019
There was a problem hiding this comment.
@hramezani Thanks for this patch 👍 I left few comment. I think we should also credit Claude ⭐ in the commit message for the initial patch.
|
@felixxm Thanks for your comment 👍. |
felixxm
reviewed
Mar 25, 2019
hramezani
force-pushed
the
ticket_28431
branch
2 times, most recently
from
54765a1
to
fd98cce
Compare
felixxm
force-pushed
the
ticket_28431
branch
2 times, most recently
from
4115eca
to
e4b3ccf
Compare
felixxm
changed the title
…gs defaults. Thanks Claude Paroz for the initial patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket_28431.
Add system check to prevent string as the default value for
BinaryField. based on @claudep suggestion on the ticket.