Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #30266 -- Kept a sequence owner when altering an AutoField/BigAutoField on PostgreSQL. #11098

Merged
merged 1 commit into from Apr 8, 2019
Merged

Fixed #30266 -- Kept a sequence owner when altering an AutoField/BigAutoField on PostgreSQL. #11098

merged 1 commit into from Apr 8, 2019

Conversation

pydolan
Copy link
Contributor

@pydolan pydolan commented Mar 19, 2019

This fixes ticket 30266.

charettes
charettes reviewed Mar 19, 2019
View reviewed changes
Copy link
Member

@charettes charettes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, the code changes looks sane but the tests should probably live in the schema test app.

@pydolan
Copy link
Contributor Author

pydolan commented Apr 6, 2019

PR updated with requested changes. I'll update the ticket as well

felixxm
felixxm reviewed Apr 8, 2019
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pydolan Thanks for this patch 👍 I would simplify tests.

tests/schema/tests.py Outdated Show resolved Hide resolved
@felixxm felixxm changed the title Fixed #30266 -- Fixed issue with postgres sequence owner disappearing from AlterField Fixed #30266 -- Prevented removing sequence owner when altering an AutoField/BigAutoField on PostgreSQL. Apr 8, 2019
@felixxm felixxm changed the title Fixed #30266 -- Prevented removing sequence owner when altering an AutoField/BigAutoField on PostgreSQL. Fixed #30266 -- Kept a sequence owner when altering an AutoField/BigAutoField on PostgreSQL. Apr 8, 2019
@felixxm felixxm merged commit f944cb3 into django:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charettes charettes charettes left review comments

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pydolan @charettes @felixxm