Allow different response classes via klass param
#11162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow any subclass of http.response.HttpResponseBase - Default to http.HttpResponse - Do a quick issubclass() check on the argument
|
Not sure exactly what's up with the failed checks - something about
|
|
That kind of change requires an accepted ticket. |
rsalmaso
reviewed
Apr 29, 2019
| from django.template import loader | ||
| from django.urls import NoReverseMatch, reverse | ||
| from django.utils.functional import Promise | ||
|
|
||
|
|
||
| def render(request, template_name, context=None, content_type=None, status=None, using=None): | ||
| def render(request, template_name, context=None, content_type=None, | ||
| status=None, using=None, klass=HttpResponse): |
There was a problem hiding this comment.
response_class instead of klass?
There was a problem hiding this comment.
Thanks, I am kind of indifferent, just used klass because I have seen it in other libraries. I'm not seeing any evidence empirically that Django has a preference but maybe it does.
|
Closing per ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
klassparameter torender()that lets user specify a response class other thanHttpResponse.http.HttpResponseBasehttp.HttpResponseissubclass()check on the argumentTicket: https://code.djangoproject.com/ticket/30429#ticket