Fixed #29352 -- Allowed specifying a Feed language. #11194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to @carltongibson I added tests, too. |
apollo13
reviewed
Apr 13, 2019
apollo13
reviewed
Apr 13, 2019
|
Not sure where the build failure against MariaDB came from, doesn't look related to me. |
rixx
force-pushed
the
ticket_29352
branch
3 times, most recently
from
4286e20
to
525ad76
Compare
felixxm
changed the title
|
Thank you for your review, I've added the changes you requested. |
|
@rixx I noticed that we have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/29352
This PR follows up on the abandoned one at #9879.
I am aware that there are still tests missing that should be added to
tests/syndication_tests, but I could use some guidance on which tests to add and where.