Fixed #26678 -- Doc'd that RelatedManager.add()/remove()/set() accepts the field the relation points to. #11245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charettes
reviewed
Apr 17, 2019
rixx
force-pushed
the
ticket_26678
branch
4 times, most recently
from
5007330
to
afd0b52
Compare
|
As suggested by @charettes, I made some changes in the tests I provided. |
felixxm
reviewed
May 1, 2019
There was a problem hiding this comment.
@rixx Thanks for this patch 🚀 I left some comments. Can we squash the last two commits with extra tests? Can we also move tests added in the m2m_and_m2o/tests.py to the many_to_many/tests.py? I think that's the right place for them.
felixxm
changed the title
|
.. and as a part of the first commit, can we fix comments for |
What do you mean by that? I moved the tests around, should look better now. |
rixx
force-pushed
the
ticket_26678
branch
2 times, most recently
from
d502635
to
bf8b2d5
Compare
…s the field the relation points to.
… with RelatedManager.add()/remove()/set().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/26678