Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #30362 -- Noted partial indexes and constraints restrictions with abstract base classes. #11275

Merged
merged 2 commits into from Apr 25, 2019
Merged

Fixed #30362 -- Noted partial indexes and constraints restrictions with abstract base classes. #11275

merged 2 commits into from Apr 25, 2019

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Apr 24, 2019

Ticket 30362.

carltongibson
carltongibson approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good.

I had a suggestion for rephrasing, but I leave it to you to adopt that or not.

Merge away! 🙂

docs/ref/models/constraints.txt Outdated Show resolved Hide resolved
docs/ref/models/indexes.txt Outdated Show resolved Hide resolved
@felixxm
Fixed #30362 -- Noted partial indexes and constraints restrictions wi…
124fa84 
…th abstract base classes.

Thanks Carlton Gibson for the review.
@felixxm
Copy link
Member Author

felixxm commented Apr 25, 2019

@carltongibson Thanks for the review 👍

@felixxm felixxm merged commit 5df3301 into django:master Apr 25, 2019
@felixxm felixxm deleted the issue-30362 branch April 25, 2019 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@felixxm @carltongibson