Ignored pywatchman.SocketTimeout in Watchman autoreloader.

[blueyed]

These are expected with the non-blocking loop.

Only with other errors, e.g. WatchmanError('empty watchman response')
after killing watchman need to check the server status.

[felixxm]

@orf Can you take a look?

[orf]

I’m confused @blueyed, can you elaborate some more on why this is needed? I’m really not sure about skipping socket timeouts here, surely they are indicative of an issue?

[blueyed]

It is not needed (i.e. does not fix a bug), but just avoids the version request every 5 seconds.

For reference: https://github.com/facebook/watchman/blob/0513bb4dc6719b49d1ee6455ac538457bc64491c/python/pywatchman/__init__.py#L271-L278

I'd even argue that we should not have a timeout here in the first place, i.e. just let it block there until there is either a response or the socket gets closed (e.g. when watchman gets killed), but thought to rather play it safe.

[blueyed]

With this it is also (easier) possible to add debug logging here for unexpected things: #11305.

[blueyed]

It requires pywatchman v3.8.0 (facebook/watchman@1e9d5cb), 4 years old.

[orf]

Looks good to me, thanks for the explanation 👍

[felixxm]

I checked and SocketTimeout had appeared in pywatchman 1.2.0. Can you add a note to the ref/django-admin.txt about minimum supported version of pywatchman? Thanks.

[felixxm]

I rebased from master and added a note about bumping supported pywatchman version to 1.2.0.

[blueyed]

Thanks, what about #11305 then?