Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #30409 -- Allowed using foreign key's attnames in unique/index_together and Index's fields. #11308

Closed
wants to merge 1 commit into from

Conversation

zeyneloz
Copy link
Contributor

See #30409
Adjusted model checks to allow field attname usage for indexes,
index_together and unique_together in model Meta class.

Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release notes?

@zeyneloz
Copy link
Contributor Author

release notes?

Thank you for the review. I updated the PR with release note.

@felixxm
Copy link
Member

felixxm commented Apr 30, 2019

IMO this doesn't qualify for a backport, so release notes are not necessary.

@felixxm felixxm changed the title Fixed #30409 -- Allow field attname usage for model indexes. Fixed #30409 -- Allowed using foreign key's attnames in unique/index_together and Index's fields. May 1, 2019
@felixxm
Copy link
Member

felixxm commented May 1, 2019

@zeyneloz Thanks for this patch 👍 I rebased from master, changed get_attname() to attname and added tests for pointing FK with field name.

@felixxm
Copy link
Member

felixxm commented May 1, 2019

Merged in 6485a5f.

@felixxm felixxm closed this May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants