Fixed #29056 -- Fixed HTML5 validation of required SelectDateWidget. #11323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngnpope
reviewed
May 5, 2019
| <option value="11">November</option> | ||
| <option value="12">December</option> | ||
| </select> | ||
|
|
There was a problem hiding this comment.
I think you can remove the blank lines as the helpers for checking HTML should ignore whitespace between tags.
There was a problem hiding this comment.
No, It doesn't. I added a test to cover the required=False case.
hramezani
force-pushed
the
ticket_29056
branch
2 times, most recently
from
b86f77c
to
a608565
Compare
|
@pope1ni Requested changes are Done |
felixxm
changed the title
placeholder attr to required SelectDateWidget rendered HTML.
|
@hramezani Thanks for this patch 👍 I simplified tests and added release notes. |
placeholder is required for "select" with "required" attribute.
|
@felixxm Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/29056