Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #28289 -- Fixed crash of RawSQL annotations on inherited model fields. #11354

Merged
merged 1 commit into from Jul 11, 2019

Conversation

cansarigol
Copy link
Contributor

Ticket : #28289

@cansarigol cansarigol force-pushed the ticket-28289 branch 2 times, most recently from 96ec27f to 1a0b400 Compare May 20, 2019 17:34
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cansarigol Thanks for this patch 👍 I left comments.

django/db/models/expressions.py Outdated Show resolved Hide resolved
tests/annotations/tests.py Outdated Show resolved Hide resolved
tests/annotations/tests.py Outdated Show resolved Hide resolved
tests/annotations/tests.py Outdated Show resolved Hide resolved
tests/annotations/tests.py Outdated Show resolved Hide resolved
tests/annotations/tests.py Outdated Show resolved Hide resolved
django/db/models/expressions.py Outdated Show resolved Hide resolved
@cansarigol
Copy link
Contributor Author

Thanks @felixxm, I've changed it as your comments.

@felixxm felixxm changed the title Fixed #28289 -- Fixed raw sql annotations with QuerySet methods on inherited model fields. Fixed #28289 -- Fixed crash of RawSQL annotations on inherited model fields. Jul 11, 2019
@felixxm felixxm merged commit 52545e7 into django:master Jul 11, 2019
@cansarigol cansarigol deleted the ticket-28289 branch July 11, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants