Refs #29444 -- Added support for fetching a returned non-integer insert values on Oracle. #11462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingjoe
force-pushed
the
oracle_pk
branch
2 times, most recently
from
db30251
to
bf86f99
Compare
|
buildbot, test on oracle. |
codingjoe
changed the title
|
@carltongibson I split the Oracle feature as requires from the main PR #9983 |
felixxm
reviewed
Jun 26, 2019
There was a problem hiding this comment.
@codingjoe Thanks for this patch, great job 🎉 I left few comments.
felixxm
changed the title
…rt values on Oracle. This is currently not actively used, since the ORM will ask the SQL compiler to only return auto fields.
|
@codingjoe Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently not actively used, since the ORM will ask the
SQL compiler to only return auto fields and none other. However
this will change in #29444.