Fixed #20034 - Ability to retrieve variables in multipart even before parsing files #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completes the removal of the distinction between core devs and specialists. Patch by Simon Meers.
Fixed some documentation on the MultiPartParser
Fix makemessage's --ignore patterns being applied to the full path instead of the file name. Thanks to nnseva for the report and the original patch.
…hecks. Thanks to edevil for the report and saz for the patch.
Thanks srusskih for the report and Aymeric Augustin for the review.
Thanks marktranchant, bmispelon, and alextreme.
Closes django#9054. The bug itself is no longer present.
The failure was triggered by a cache leak.
Made introspection always return a unicode as column name on Oracle. Thanks aaugustin for review and suggestion to use force_text().
Fixed #20433: extracted catalog compilation code from view.
It can fail in hard-to-diagnose ways.
…t_context_data kwargs. This is so MultipleObjectMixin can be used in the same way as SingleObjectMixin.
Fixes #20235 - MultipleObjectMixin requires object_list in kwargs
Fixed django#13546 -- Easier handling of localize field options in ModelForm
Thanks Stephane Benchimol for the report and the initial script and mfandreas for the patch.
… languages when matching Accept-Language
Fixed #19919: get_language_from_request() disregards en-us and en
Fixed argument order for localized_fields to ensure backwards compatibility
Also, streamline the use of 0 and None between cache backends.
#20432: Fix for GroupAdmin test
Removing a backend configured in AUTHENTICATION_BACKENDS should not raise an exception for existing sessions, but should make already logged-in users disconnect. Thanks Bradley Ayers for the report.
Fixed #18761 -- Added whitespace stripping to URLField and SlugField.
…ields/variables are successfully parsed from multipart POST request. Fix for #20034.
|
Awesome! Great work! |
|
I've added a comment to the ticket. Could you open a new PR if you could address those issues? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about Trac ticket no. 20034, alters pull request for #898, verifies it, adds tests and documentation.
The new method
variable_complete, if supplied by the file upload handler, works similarly tofile_completeand allows to raiseStopFutureHandlersif future handlers should not be allowed to parse the variable.This is my first PR to Django. Please verify if there is something lacking in it. Thanks.