Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixed #20034 - Ability to retrieve variables in multipart even before parsing files #1148

Closed
wants to merge 33 commits into from
@tadeck

This is about Trac ticket no. 20034, alters pull request for #898, verifies it, adds tests and documentation.

The new method variable_complete, if supplied by the file upload handler, works similarly to file_complete and allows to raise StopFutureHandlers if future handlers should not be allowed to parse the variable.

This is my first PR to Django. Please verify if there is something lacking in it. Thanks.

hydrogen18 and others added some commits
@hydrogen18 hydrogen18 Corrected documentation on the constructor arguments of MultiPartParser c278e56
@aaugustin aaugustin Reorganize committers list chronologically.
This completes the removal of the distinction between core devs and
specialists.

Patch by Simon Meers.
ee11d32
@mjtamlyn mjtamlyn Merge pull request #1082 from hydrogen18/master
Fixed some documentation on the MultiPartParser
1d3d040
@bmispelon bmispelon Fixed #20422 -- Applied makemessage's --ignore patterns to full path
Fix makemessage's --ignore patterns being applied to the full path
instead of the file name. Thanks to nnseva for the report and the
original patch.
9012a9e
@apollo13 apollo13 Fixed #20411 -- Don't let invalid referers blow up CSRF same origin c…
…hecks.

Thanks to edevil for the report and saz for the patch.
051cb1f
@claudep claudep Fixed #20356 -- Prevented crash when HTTP_REFERER contains non-ascii
Thanks srusskih for the report and Aymeric Augustin for the review.
8fd44b2
@zsiciarz zsiciarz Fixed #20294 -- Documented context processors in TemplateResponseMixin. 0b07416
@aaugustin aaugustin Fixed #20408 -- Clarified that values_list() doesn't return a list.
Thanks marktranchant, bmispelon, and alextreme.
7b85ef9
@senko senko Added test for multipart, non form-data POST.
Closes #9054. The bug itself is no longer present.
566e284
@jacobb jacobb #20432: Fix for GroupAdmin test 029c690
@jacobb jacobb Fixed #20432 -- Test failure in admin_views.
The failure was triggered by a cache leak.
3401152
Shai Berger Fixed #20386 - Introspection problem on Oracle
Made introspection always return a unicode as column name on Oracle.
Thanks aaugustin for review and suggestion to use force_text().
215647c
zyegfryed Fixed #20433: Extract catalog compilation code from javascript_catalo…
…g view.
5e208d5
@aaugustin aaugustin Merge pull request #1090 from zyegfryed/ticket_20433
Fixed #20433: extracted catalog compilation code from view.
06603d1
@aaugustin aaugustin Made test introduced in 566e284 pass on Python 3. 4bed64c
@aaugustin aaugustin Fixed #20402: removed as-limit from uWSGI example.
It can fail in hard-to-diagnose ways.
be826aa
@dracos dracos Fixed #20235 -- Use self.object_list if object_list not present in ge…
…t_context_data kwargs.

This is so MultipleObjectMixin can be used in the same way as
SingleObjectMixin.
1c921cf
@erikr erikr Fixed #13546 -- Easier handling of localize field options in ModelForm 756b81d
@mjtamlyn mjtamlyn Merge pull request #1083 from Markush2010/ticket20235
Fixes #20235 - MultipleObjectMixin requires object_list in kwargs
ef73a8e
@apollo13 apollo13 Merge pull request #1084 from erikr/master
Fixed #13546 -- Easier handling of localize field options in ModelForm
16683f2
@claudep claudep Fixed #20269 -- Adapted PostGIS template create script for CentOS/RHEL
Thanks Stephane Benchimol for the report and the initial script and
mfandreas for the patch.
90f1170
@ambv ambv Fixes #19919: get_language_from_request() disregards "en-us" and "en"…
… languages

when matching Accept-Language
92ebb29
@erikr erikr Fixed argument order for localized_fields to ensure backwards compati…
…bility
1c16956
@aaugustin aaugustin Merge pull request #1100 from ambv/issue19919
Fixed #19919: get_language_from_request() disregards en-us and en
cac7b44
@apollo13 apollo13 Merge pull request #1101 from erikr/master
Fixed argument order for localized_fields to ensure backwards compatibility
e0df647
@jacobb jacobb Fixed #9595 -- Allow non-expiring cache timeouts.
Also, streamline the use of 0 and None between cache backends.
89955cc
@dstufft dstufft Merge pull request #1088 from jacobb/upstream
#20432: Fix for GroupAdmin test
a0c0cc9
@jorgebastida jorgebastida Fixed #18998 - Prevented session crash when auth backend removed
Removing a backend configured in AUTHENTICATION_BACKENDS should not
raise an exception for existing sessions, but should make already
logged-in users disconnect.
Thanks Bradley Ayers for the report.
dc43fbc
@claudep claudep Slightly reworked imports in contrib.auth.__init__ 710c59b
@aaugustin aaugustin Merge pull request #1113 from denibertovic/master
Fixed #18761 -- Added whitespace stripping to URLField and SlugField.
7d050e8
@oliviersels oliviersels Fixed #19436 -- Don't log warnings in ensure_csrf_cookie. 63a9555
@lechup

On what Python did you tried your tests? On my setup I get 4 errors, with 9012833 i18n/tests.py I do not have those errors...

my python==2.7.3

Both Python 2.7.3 and Python 3.3.1. No errors, nobody during the DjangoCon sprints complained after it's been integrated. Your comment will be more helpful with a traceback.

By nobody I also mean our kindly Mr Jenkins: http://ci.djangoproject.com/job/Django/2659/

http://pastebin.com/Nvkn1sK0

Maybe I'll try find You tommorow at sprint? :)

The paths in your log suggest you are trying to run tests against a different copy of Django, installed in your virtualenv. Try the following:

  1. Create a new virtualenv without installing Django in it.
  2. Create a django.pth file in the virtualenv's site-packages with the path /home/lechup/github/django/ in it.
  3. Run tests again.

Also, do you know of a concept called pastebin? :neckbeard: GitHub has gist for instance.

Thanks for pointers, actually /home/lechup/.virtualenvs/django-sprint/local/lib/python2.7/site-packages/django/ is a symlink to /home/lechup/github/django/django/ .

I'll try that .pth thing, but I think it is not the case.

PS: Pastebin? I though about it but to late (when I've already seen big letters)... Thanks for pointing this out. :+1:

rfkrocktk and others added some commits
@rfkrocktk

Awesome! Great work!

@timgraham
Owner

I've added a comment to the ticket. Could you open a new PR if you could address those issues? Thanks!

@timgraham timgraham closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 17, 2013
  1. @hydrogen18
Commits on May 18, 2013
  1. @aaugustin

    Reorganize committers list chronologically.

    aaugustin authored
    This completes the removal of the distinction between core devs and
    specialists.
    
    Patch by Simon Meers.
  2. @mjtamlyn

    Merge pull request #1082 from hydrogen18/master

    mjtamlyn authored
    Fixed some documentation on the MultiPartParser
  3. @bmispelon @claudep

    Fixed #20422 -- Applied makemessage's --ignore patterns to full path

    bmispelon authored claudep committed
    Fix makemessage's --ignore patterns being applied to the full path
    instead of the file name. Thanks to nnseva for the report and the
    original patch.
  4. @apollo13

    Fixed #20411 -- Don't let invalid referers blow up CSRF same origin c…

    apollo13 authored
    …hecks.
    
    Thanks to edevil for the report and saz for the patch.
  5. @claudep

    Fixed #20356 -- Prevented crash when HTTP_REFERER contains non-ascii

    claudep authored
    Thanks srusskih for the report and Aymeric Augustin for the review.
  6. @zsiciarz @apollo13
  7. @aaugustin

    Fixed #20408 -- Clarified that values_list() doesn't return a list.

    aaugustin authored
    Thanks marktranchant, bmispelon, and alextreme.
  8. @senko @aaugustin

    Added test for multipart, non form-data POST.

    senko authored aaugustin committed
    Closes #9054. The bug itself is no longer present.
  9. @jacobb

    #20432: Fix for GroupAdmin test

    jacobb authored
  10. @jacobb @aaugustin

    Fixed #20432 -- Test failure in admin_views.

    jacobb authored aaugustin committed
    The failure was triggered by a cache leak.
  11. Fixed #20386 - Introspection problem on Oracle

    Shai Berger authored
    Made introspection always return a unicode as column name on Oracle.
    Thanks aaugustin for review and suggestion to use force_text().
  12. @aaugustin

    Merge pull request #1090 from zyegfryed/ticket_20433

    aaugustin authored
    Fixed #20433: extracted catalog compilation code from view.
  13. @aaugustin
  14. @aaugustin

    Fixed #20402: removed as-limit from uWSGI example.

    aaugustin authored
    It can fail in hard-to-diagnose ways.
  15. @dracos @MarkusH

    Fixed #20235 -- Use self.object_list if object_list not present in ge…

    dracos authored MarkusH committed
    …t_context_data kwargs.
    
    This is so MultipleObjectMixin can be used in the same way as
    SingleObjectMixin.
  16. @erikr
  17. @mjtamlyn

    Merge pull request #1083 from Markush2010/ticket20235

    mjtamlyn authored
    Fixes #20235 - MultipleObjectMixin requires object_list in kwargs
  18. @apollo13

    Merge pull request #1084 from erikr/master

    apollo13 authored
    Fixed #13546 -- Easier handling of localize field options in ModelForm
  19. @claudep

    Fixed #20269 -- Adapted PostGIS template create script for CentOS/RHEL

    claudep authored
    Thanks Stephane Benchimol for the report and the initial script and
    mfandreas for the patch.
  20. @ambv

    Fixes #19919: get_language_from_request() disregards "en-us" and "en"…

    ambv authored
    … languages
    
    when matching Accept-Language
  21. @erikr
  22. @aaugustin

    Merge pull request #1100 from ambv/issue19919

    aaugustin authored
    Fixed #19919: get_language_from_request() disregards en-us and en
  23. @apollo13

    Merge pull request #1101 from erikr/master

    apollo13 authored
    Fixed argument order for localized_fields to ensure backwards compatibility
  24. @jacobb @aaugustin

    Fixed #9595 -- Allow non-expiring cache timeouts.

    jacobb authored aaugustin committed
    Also, streamline the use of 0 and None between cache backends.
  25. @dstufft

    Merge pull request #1088 from jacobb/upstream

    dstufft authored
    #20432: Fix for GroupAdmin test
  26. @jorgebastida @claudep

    Fixed #18998 - Prevented session crash when auth backend removed

    jorgebastida authored claudep committed
    Removing a backend configured in AUTHENTICATION_BACKENDS should not
    raise an exception for existing sessions, but should make already
    logged-in users disconnect.
    Thanks Bradley Ayers for the report.
  27. @claudep
  28. @aaugustin

    Merge pull request #1113 from denibertovic/master

    aaugustin authored
    Fixed #18761 -- Added whitespace stripping to URLField and SlugField.
  29. @oliviersels @aaugustin
Commits on May 19, 2013
  1. @rfkrocktk @tadeck

    Modified upload handler API to be able to invoke callbacks when new f…

    rfkrocktk authored tadeck committed
    …ields/variables
    
    are successfully parsed from multipart POST request. Fix for #20034.
  2. @tadeck
Something went wrong with that request. Please try again.