Refs #29379 -- Moved autocomplete attribute to UsernameField. #11623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carltongibson Would you mind looking at this follow up to PR #11070? |
|
Hey @pope1ni, no problem! (If you ever want me to look at things, the "Request a review" thingy at the side puts it on my short(er) list, and gets me a notification. 😉) |
I think you have to be an organisation member or a repository collaborator to do that. I'm a lowly author/contributor 😃 |
|
Hmmm. OK, that's somewhat ridiculous. I assumed you were an Org member. I shall discuss this with the Powers on the Mount 😀 (Awaiting resolution of DEP 10 things may be On Hold there, but...) |
Moving the autocomplete attribute into UsernameField allows this to work for custom forms making use of UsernameField, removes some duplication in the code, and keeps consistency with the autocapitalize attribute that is already defined on UsernameField.
|
Any update on this one @carltongibson? |
carltongibson
approved these changes
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #29379.
Moving the
autocompleteattribute intoUsernameFieldallows this to work for custom forms making use ofUsernameField, removes some duplication in the code, and keeps consistency with theautocapitalizeattribute that is already defined onUsernameField.