Fixed #18763 -- Added ModelBackend/UserManager.with_perm() methods. #11625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudep
reviewed
Aug 3, 2019
ngnpope
commented
Aug 3, 2019
felixxm
force-pushed
the
ticket-18763
branch
2 times, most recently
from
b6ef8f7
to
34ddd01
Compare
|
Thanks for the edits, @felixxm. Is there anything else that needs sorting out here to get this merged? |
|
@pope1ni I'm working on tests and I should push final edits in few minutes. |
felixxm
force-pushed
the
ticket-18763
branch
2 times, most recently
from
e909277
to
c622b97
Compare
Co-authored-by: Nick Pope <nick.pope@flightdataservices.com>
felixxm
changed the title
felixxm
changed the title
|
@pope1ni @berkerpeksag Thanks 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #18763.
Supersedes PR #7153
I've picked this up as I'd really love to see this make it into 3.0 after ~3 years!
I hope you don't mind @berkerpeksag ...
@felixxm I've addressed the outstanding review comments and managed to change over to using
Exists()so that we can drop.distinct(). I've had to use.annotate()for now, but that could be simplified when #8119 lands.