Tweaked loaddata command to re-use a calculated value. #11637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngnpope
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
LGTM.
@carltongibson This is a straightforward simplification.
carltongibson
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
OK, yes, thanks. Let's have this.
find_fixtures() relies on parse_name() which already uses serialization_formats, so somebody has to be trying hard for this to be an issue. (Which I will remember when we get the issue report. 😀)
Thanks @0x55AAh, and thanks for the review @pope1ni.
I will rebase now.
Removed a dublicated call to get_public_serializer_formats which had already populated self.serialization_formats. Thanks to Nick Pope for review.
carltongibson
force-pushed
the
patch-1
branch
from
cdba8c2
to
bfcc46e
Compare
carltongibson
changed the title
|
@0x55AAh Welcome aboard! ⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dublicated call get_public_serializer_formats on loaddata command