Refs #27795 -- Removed unnecessary force_bytes() calls in uri_to_iri().

[jdufresne]

The argument to uri_to_iri() is always a string, so can safely call .encode().

The value returned from urllib.parse.quote() is always a string, so can safely call .encode().

https://code.djangoproject.com/ticket/27795

[carltongibson]

Hmmm. I just a bit worried about this from the docs:

Takes a URI in ASCII bytes ...

Is the argument always a string? Rather than bytes? (It seems so in the tests but...)

What do you think?

[jdufresne]

I believe the docs are incorrect and should be changed to something like:

Takes a URI of type str composed of ASCII ...

No where internally (code and tests) does Django pass bytes to this function.

WDYT?

[jdufresne]

Hmm, maybe you're right that it is better to be safe here. I've limited the change to just the return value of quote() which we know is always str.

[carltongibson]

Thanks @jdufresne. I’ll have a look at this again in the morning (but seems fine).

I think I agree in principle in the iri case but I bet there’s someone out there passing bytes...

[carltongibson]

Yes, super. Thanks @jdufresne.