Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #30739 -- Fixed exclusion of multi-valued lookup against outer rhs. #11734

Merged
merged 2 commits into from
Sep 2, 2019
Merged

Fixed #30739 -- Fixed exclusion of multi-valued lookup against outer rhs. #11734

merged 2 commits into from
Sep 2, 2019

Commits on Sep 2, 2019

  1. Refs #28442 -- Adjusted related lookups handling of expression rhs. 

    Expressions should never be prepared as other Lookup.get_prep_lookup
implementations hint at by returning early on the presence of the
resolve_expression attribute.

The previous solution was only handling lookups against related fields
pointing at AutoFields and would break for foreign keys to other fields.

It was also causing bidirectional coupling between model fields and
expressions which the method level import of OuterRef was a symptom of.
    @charettes @felixxm
    charettes authored and felixxm committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    600628f View commit details
    Browse the repository at this point in the history

  2. Fixed #30739 -- Fixed exclusion of multi-valued lookup against outer … 

    …rhs.

OuterRef right hand sides have to be nested, just like F rhs have to,
during the subquery pushdown split_exclude performs to ensure they are
resolved against the outer query aliases.
    @charettes @felixxm
    charettes authored and felixxm committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    13a8884 View commit details
    Browse the repository at this point in the history