Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates: Sites reference and assertNumQueries(). #11791

Merged
merged 2 commits into from
Dec 20, 2019

Conversation

garrypolley
Copy link
Contributor

This PR contains two documentation updates.

  1. To address the request here: Removed outdated examples of flatpages on Django. #11667 -- my goal is minimal changes while still keep the good example in place.
  2. Hopefully make the assertNumQueries be more obvious that you can pass using as a kwarg. I got confused when I read the docs and the example talked about the lambda for the call.

@garrypolley garrypolley changed the title Documentation updates Documentation updates: Sites reference and assertNumQueries Sep 18, 2019
@garrypolley
Copy link
Contributor Author

How do I run the docs locally and get them to look like the current styles on djangoproject? When I run locally they look like the previous styles with the greens.

@garrypolley
Copy link
Contributor Author

I do not want to seem impatient or rude. @carltongibson Are there updates I should make to this PR? I made this PR based on the feedback of #11667

docs/ref/contrib/sites.txt Outdated Show resolved Hide resolved
@felixxm felixxm self-assigned this Dec 20, 2019
@felixxm felixxm changed the title Documentation updates: Sites reference and assertNumQueries Documentation updates: Sites reference and assertNumQueries(). Dec 20, 2019
@felixxm
Copy link
Member

felixxm commented Dec 20, 2019

@garrypolley Thanks 👍

@felixxm felixxm merged commit 0b698ea into django:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants