Fixed #30821 -- Added ExtractIsoWeekYear database function and iso_week_day lookup. #11856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spookyvision
force-pushed
the
ticket_30821
branch
from
32b7747
to
6f71513
Compare
felixxm
changed the title
felixxm
reviewed
Oct 1, 2019
There was a problem hiding this comment.
@spookyvision Thanks for this patch 👍 I left few comments.
Please add also iso_week_day to lookups that are not allowed for DurationField and a test case for that (db_functions.datetime.test_extract_trunc.DateFunctionWithTimeZoneTests.test_extract_duration_unsupported_lookups).
Also tests for ExtractIsoWeekDay are missing (see tests/db_functions/datetime/test_extract_trunc.py for examples).
felixxm
reviewed
Oct 1, 2019
|
I've added test cases for |
felixxm
force-pushed
the
ticket_30821
branch
2 times, most recently
from
eae3c62
to
ec06827
Compare
|
@spookyvision Thanks 🚀 ! I rebased from master, squashed commits, pushed minor edits, and added few more tests and examples in docs. Welcome aboard ⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.