Fixed #15742 -- Fixed an example of collecting selected objects in ModelAdmin.actions docs. #12016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danthedeckie
force-pushed
the
docs-admin-actions-use-queryset
branch
from
fb76f4f
to
d93e9b9
Compare
felixxm
changed the title
felixxm
force-pushed
the
docs-admin-actions-use-queryset
branch
from
d93e9b9
to
9c14424
Compare
felixxm
changed the title
felixxm
changed the title
|
@danthedeckie Thanks 👍 I removed unused import and pushed minor optimization to this example. I also added a separate commit to removed unused import in Django. |
… in ModelAdmin.actions docs. The queryset argument is already filtered, and request.POST doesn't contain all selected objects when "Select All" is used.
felixxm
force-pushed
the
docs-admin-actions-use-queryset
branch
from
9c14424
to
4c45b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( https://docs.djangoproject.com/en/2.2/ref/contrib/admin/actions/#actions-that-provide-intermediate-pages )
/docs/ref/contrib/admin/actions.txtin paragraph
Actions that provide intermediate pagesrecommends directly accessing the form values:
selected = request.POST.getlist(admin.ACTION_CHECKBOX_NAME)to get a list of selected ids. This fails to take into account if the
select allbox has been selected.This patch changes one line to suggest using the queryset to get the IDs, which results in the correct behaviour.