Fixed #31006 -- Doc'd backslash escaping in date/time template filters. #12128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryancheley What do you think about my suggestion? Ticket is also about documenting this in |
|
@felixxm I think its a great idea and will make update and commit later today or tomorrow. |
felixxm
reviewed
Nov 25, 2019
docs/ref/templates/builtins.txt
Outdated
| It is the {% now "jS \o\f F" %} | ||
|
|
||
| This would display as "It is the 4th of September". | ||
|
|
There was a problem hiding this comment.
I don't think that we need a separate example in the date docs. I would rather add a short note to the existing example for es, e.g.
...
outputs ``9 de Enero de 2008`` (the ``DATE_FORMAT`` format specifier for the
``es`` locale is ``r'j \d\e F \d\e Y'``). Both "d" and "e" are
backslash-escaped, because otherwise each is a format string that displays the
day and the timezone name, respectively.
There was a problem hiding this comment.
OK. I think I see what you're saying. I'll try again over the holiday weekend. Thanks!
There was a problem hiding this comment.
@felixxm I've made the change suggested. Thanks!
felixxm
changed the title
|
@ryancheley Thanks 👍 I rebased from master and pushed edits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue 31006