Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #31069, Refs #26431 -- Doc'd RegexPattern behavior change in passing optional named groups in Django 3.0. #12203

Merged
merged 1 commit into from Dec 12, 2019

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Dec 11, 2019

Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramezani Thanks for this patch 👍 I left wording suggestions, please add also release notes under Backwards incompatible changes in 3.0 -> Miscellaneous.

docs/topics/http/urls.txt Outdated Show resolved Hide resolved
docs/topics/http/urls.txt Outdated Show resolved Hide resolved
@hramezani
Copy link
Member Author

hramezani commented Dec 11, 2019

@felixxm Thanks for your review and suggestion.
what do you think about the following release note for Backwards incompatible changes:

*‌ The keyword arguments with ``None`` values in matched URL pattern are no
  longer get passed to view, also for not provided named parts.

@felixxm
Copy link
Member

felixxm commented Dec 11, 2019

We can take a releases/3.0.1.txt as a pattern 🤔 , e.g.:

* ``RegexPattern``, used by :func:`~django.urls.re_path`, no longer return a
  keyword argument with ``None`` value to be passed to the view for the
  optional named group that is missing.

@hramezani
Copy link
Member Author

  • RegexPattern, used by :func:~django.urls.re_path, no longer return a
    keyword argument with None value to be passed to the view for the
    optional named group that is missing.

Thanks, I just replaced no longer return with no longer returns.

docs/topics/http/urls.txt Outdated Show resolved Hide resolved
@felixxm felixxm changed the title Fixed #31069 -- Documented change in behavior for optional re matches. Fixed #31069, Refs #26431 -- Doc'd RegexPattern behavior change in passing optional named groups in Django 3.0. Dec 12, 2019
@felixxm
Copy link
Member

felixxm commented Dec 12, 2019

@hramezani Thanks 👍

@felixxm felixxm merged commit 9736137 into django:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants