Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added guidelines for assertIs() usage. #12243

Merged
merged 1 commit into from Dec 30, 2019
Merged

Added guidelines for assertIs() usage. #12243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/internals/contributing/writing-code/coding-style.txt
View file
Open in desktop
Expand Up @@ -71,6 +71,11 @@ Python style
and :meth:`~unittest.TestCase.assertWarnsRegex` only if you need regular
expression matching.

Use :meth:`assertIs(…, True/False)<unittest.TestCase.assertIs>` for testing
boolean values, rather than :meth:`~unittest.TestCase.assertTrue` and
:meth:`~unittest.TestCase.assertFalse`, so you can check the actual boolean
value, not the truthiness of the expression.

* In test docstrings, state the expected behavior that each test demonstrates.
Don't include preambles such as "Tests that" or "Ensures that".

Expand Down